Skip to content

Commit

Permalink
[PATCH] serial: fix comments in 8250.c
Browse files Browse the repository at this point in the history
Fix the formatting of some comments in 8250.c, and add a note that the
register_serial / unregister_serial shouldn't be used in new code.

We do this here in preference to adding to linux/serial.h, since that is used
by a number of non-8250 drivers which pretend to be 8250.  It is not known
whether it would be appropriate to do so.

Signed-off-by: Russell King <rmk@arm.linux.org.uk>

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Russell King authored and Linus Torvalds committed Apr 16, 2005
1 parent c907132 commit 23907eb
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions drivers/serial/8250.c
Original file line number Diff line number Diff line change
Expand Up @@ -1065,8 +1065,10 @@ receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
tty_flip_buffer_push(tty);
spin_lock(&up->port.lock);
}
/* If this failed then we will throw away the
bytes but must do so to clear interrupts */
/*
* If this failed then we will throw away the
* bytes but must do so to clear interrupts
*/
}
ch = serial_inp(up, UART_RX);
flag = TTY_NORMAL;
Expand Down Expand Up @@ -1106,7 +1108,7 @@ receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
up->port.icount.overrun++;

/*
* Mask off conditions which should be ingored.
* Mask off conditions which should be ignored.
*/
lsr &= up->port.read_status_mask;

Expand Down Expand Up @@ -2570,6 +2572,9 @@ MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR);
* If this fails an error is returned.
*
* On success the port is ready to use and the line number is returned.
*
* Note: this function is deprecated - use serial8250_register_port
* instead.
*/
int register_serial(struct serial_struct *req)
{
Expand Down Expand Up @@ -2624,6 +2629,9 @@ EXPORT_SYMBOL(register_serial);
*
* Remove one serial port. This may not be called from interrupt
* context. We hand the port back to our local PM control.
*
* Note: this function is deprecated - use serial8250_unregister_port
* instead.
*/
void unregister_serial(int line)
{
Expand Down

0 comments on commit 23907eb

Please sign in to comment.