Skip to content

Commit

Permalink
drivers/block/drbd/drbd_receiver.c: correct NULL test
Browse files Browse the repository at this point in the history
Test the just-allocated value for NULL rather than some other value.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,y;
statement S;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
-   y
+   x
       == NULL)
 S
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Julia Lawall authored and Jens Axboe committed Jan 11, 2010
1 parent 875feb6 commit 2397816
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/block/drbd/drbd_receiver.c
Original file line number Diff line number Diff line change
Expand Up @@ -3945,7 +3945,7 @@ static int drbd_do_auth(struct drbd_conf *mdev)
}

right_response = kmalloc(resp_size, GFP_NOIO);
if (response == NULL) {
if (right_response == NULL) {
dev_err(DEV, "kmalloc of right_response failed\n");
rv = 0;
goto fail;
Expand Down

0 comments on commit 2397816

Please sign in to comment.