Skip to content

Commit

Permalink
staging: r8188eu: Remove wrappers around vmalloc and vzalloc
Browse files Browse the repository at this point in the history
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Larry Finger authored and Greg Kroah-Hartman committed Feb 7, 2014
1 parent 7d901c6 commit 2397c6e
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 34 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/rtl8188eu/core/rtw_mlme.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ int _rtw_init_mlme_priv (struct adapter *padapter)

_func_enter_;

/* We don't need to memset padapter->XXX to zero, because adapter is allocated by rtw_zvmalloc(). */
/* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */

pmlmepriv->nic_hdl = (u8 *)padapter;

Expand All @@ -62,7 +62,7 @@ _func_enter_;

_rtw_memset(&pmlmepriv->assoc_ssid, 0, sizeof(struct ndis_802_11_ssid));

pbuf = rtw_zvmalloc(MAX_BSS_CNT * (sizeof(struct wlan_network)));
pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network)));

if (pbuf == NULL) {
res = _FAIL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/core/rtw_mp.c
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv)
/* Init xmit extension buff */
_rtw_init_queue(&pxmitpriv->free_xmit_extbuf_queue);

pxmitpriv->pallocated_xmit_extbuf = rtw_zvmalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);
pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);

if (pxmitpriv->pallocated_xmit_extbuf == NULL) {
RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_extbuf fail!\n"));
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/core/rtw_recv.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ _func_enter_;

rtw_os_recv_resource_init(precvpriv, padapter);

precvpriv->pallocated_frame_buf = rtw_zvmalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ);
precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ);

if (precvpriv->pallocated_frame_buf == NULL) {
res = _FAIL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv)

_func_enter_;

pstapriv->pallocated_stainfo_buf = rtw_zvmalloc(sizeof(struct sta_info) * NUM_STA + 4);
pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);

if (!pstapriv->pallocated_stainfo_buf)
return _FAIL;
Expand Down
8 changes: 4 additions & 4 deletions drivers/staging/rtl8188eu/core/rtw_xmit.c
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)

_func_enter_;

/* We don't need to memset padapter->XXX to zero, because adapter is allocated by rtw_zvmalloc(). */
/* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */

spin_lock_init(&pxmitpriv->lock);
sema_init(&pxmitpriv->xmit_sema, 0);
Expand All @@ -91,7 +91,7 @@ _func_enter_;
Please also apply free_txobj to link_up all the xmit_frames...
*/

pxmitpriv->pallocated_frame_buf = rtw_zvmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4);
pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4);

if (pxmitpriv->pallocated_frame_buf == NULL) {
pxmitpriv->pxmit_frame_buf = NULL;
Expand Down Expand Up @@ -129,7 +129,7 @@ _func_enter_;
_rtw_init_queue(&pxmitpriv->free_xmitbuf_queue);
_rtw_init_queue(&pxmitpriv->pending_xmitbuf_queue);

pxmitpriv->pallocated_xmitbuf = rtw_zvmalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4);
pxmitpriv->pallocated_xmitbuf = vzalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4);

if (pxmitpriv->pallocated_xmitbuf == NULL) {
RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_buf fail!\n"));
Expand Down Expand Up @@ -171,7 +171,7 @@ _func_enter_;
/* Init xmit extension buff */
_rtw_init_queue(&pxmitpriv->free_xmit_extbuf_queue);

pxmitpriv->pallocated_xmit_extbuf = rtw_zvmalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);
pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);

if (pxmitpriv->pallocated_xmit_extbuf == NULL) {
RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_extbuf fail!\n"));
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/hal/odm_interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/* ODM Memory relative API. */
void ODM_AllocateMemory(struct odm_dm_struct *pDM_Odm, void **pPtr, u32 length)
{
*pPtr = rtw_zvmalloc(length);
*pPtr = vzalloc(length);
}

/* length could be ignored, used to detect memory leakage. */
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ void rtw_IOL_cmd_tx_pkt_buf_dump(struct adapter *Adapter, int data_len)
u32 fifo_data, reg_140;
u32 addr, rstatus, loop = 0;
u16 data_cnts = (data_len/8)+1;
u8 *pbuf = rtw_zvmalloc(data_len+10);
u8 *pbuf = vzalloc(data_len+10);
DBG_88E("###### %s ######\n", __func__);

rtw_write8(Adapter, REG_PKT_BUFF_ACCESS_CTRL, TXPKT_BUF_SELECT);
Expand Down
4 changes: 0 additions & 4 deletions drivers/staging/rtl8188eu/include/osdep_service.h
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,10 @@ extern unsigned char WPA_TKIP_CIPHER[4];
extern unsigned char RSN_TKIP_CIPHER[4];

#define rtw_update_mem_stat(flag, sz) do {} while (0)
u8 *_rtw_vmalloc(u32 sz);
u8 *_rtw_zvmalloc(u32 sz);
void _rtw_vmfree(u8 *pbuf, u32 sz);
u8 *_rtw_zmalloc(u32 sz);
u8 *_rtw_malloc(u32 sz);
void _rtw_mfree(u8 *pbuf, u32 sz);
#define rtw_vmalloc(sz) _rtw_vmalloc((sz))
#define rtw_zvmalloc(sz) _rtw_zvmalloc((sz))
#define rtw_vmfree(pbuf, sz) _rtw_vmfree((pbuf), (sz))
#define rtw_malloc(sz) _rtw_malloc((sz))
#define rtw_zmalloc(sz) _rtw_zmalloc((sz))
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -5650,7 +5650,7 @@ static int rtw_wx_set_priv(struct net_device *dev,
return -EFAULT;

len = dwrq->length;
ext = rtw_vmalloc(len);
ext = vmalloc(len);
if (!ext)
return -ENOMEM;

Expand Down
18 changes: 1 addition & 17 deletions drivers/staging/rtl8188eu/os_dep/osdep_service.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,22 +55,6 @@ u32 rtw_atoi(u8 *s)
return num;
}

inline u8 *_rtw_vmalloc(u32 sz)
{
u8 *pbuf;
pbuf = vmalloc(sz);
return pbuf;
}

inline u8 *_rtw_zvmalloc(u32 sz)
{
u8 *pbuf;
pbuf = _rtw_vmalloc(sz);
if (pbuf != NULL)
memset(pbuf, 0, sz);
return pbuf;
}

inline void _rtw_vmfree(u8 *pbuf, u32 sz)
{
vfree(pbuf);
Expand Down Expand Up @@ -252,7 +236,7 @@ struct net_device *rtw_alloc_etherdev(int sizeof_priv)

pnpi = netdev_priv(pnetdev);

pnpi->priv = rtw_zvmalloc(sizeof_priv);
pnpi->priv = vzalloc(sizeof_priv);
if (!pnpi->priv) {
free_netdev(pnetdev);
pnetdev = NULL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/os_dep/usb_intf.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
struct net_device *pnetdev = NULL;
int status = _FAIL;

padapter = (struct adapter *)rtw_zvmalloc(sizeof(*padapter));
padapter = (struct adapter *)vzalloc(sizeof(*padapter));
if (padapter == NULL)
goto exit;
padapter->dvobj = dvobj;
Expand Down

0 comments on commit 2397c6e

Please sign in to comment.