Skip to content

Commit

Permalink
drm/i915: fully switch off overlay when not in use
Browse files Browse the repository at this point in the history
Now that the cache flushing of the memory based overlay regs works,
we can safely switch off the overlay. Beforehand it was only disabled
(like in userspace).

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Eric Anholt <eric@anholt.net>
  • Loading branch information
Daniel Vetter authored and Eric Anholt committed Nov 5, 2009
1 parent 02e792f commit 240a2d1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/gpu/drm/i915/intel_overlay.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ static int intel_overlay_off(struct intel_overlay *overlay)
}

/* turn overlay off */
/* this is not done in userspace!
BEGIN_LP_RING(6);
OUT_RING(MI_FLUSH);
OUT_RING(MI_NOOP);
Expand All @@ -338,7 +337,7 @@ static int intel_overlay_off(struct intel_overlay *overlay)
DRM_ERROR("intel overlay: ring sync failed, hw likely wedged\n");
overlay->hw_wedged = 1;
return ret;
}*/
}

overlay->active = 0;

Expand Down

0 comments on commit 240a2d1

Please sign in to comment.