---

yaml --- r: 215965 b: refs/heads/master c: 116389e h: refs/heads/master i: 215963: 68b8afd v: v3
git-mirror · Aug 30, 2010 · 2422fc0 · 2422fc0
1 parent 116bf9e
commit 2422fc0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: c3af2eaf7a3257f7b44165ec487215574c47fd32
+refs/heads/master: 116389ed21e4ad88f65e7ec5ed6ca224acb89115
diff --git a/trunk/drivers/edac/i7300_edac.c b/trunk/drivers/edac/i7300_edac.c
@@ -841,6 +841,15 @@ static int decode_mtr(struct i7300_pvt *pvt,
 	p_csrow->grain = 8;
 	p_csrow->nr_pages = dinfo->megabytes << 8;
 	p_csrow->mtype = MEM_FB_DDR2;
+
+	/*
+	 * FIXME: the type of error detection actually depends of the
+	 * mode of operation. When it is just one single memory chip, at
+	 * socket 0, channel 0, it uses  8-byte-over-32-byte SECDED+ code.
+	 * In normal or mirrored mode, it uses Single Device Data correction,
+	 * with the possibility of using an extended algorithm for x8 memories
+	 * See datasheet Sections 7.3.6 to 7.3.8
+	 */
 	p_csrow->edac_mode = EDAC_S8ECD8ED;
 
 	/* ask what device type on this row */