Skip to content

Commit

Permalink
Staging: comedi: make comedi_alloc_board_minor local to comedi core
Browse files Browse the repository at this point in the history
No one outside of the comedi core calls this function, so create
an internal.h file to put the prototype in, and don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed May 11, 2010
1 parent 181bd67 commit 242e7ad
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
3 changes: 1 addition & 2 deletions drivers/staging/comedi/comedi_fops.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
#include <linux/io.h>
#include <linux/uaccess.h>

/* #include "kvmem.h" */
#include "internal.h"

MODULE_AUTHOR("http://www.comedi.org");
MODULE_DESCRIPTION("Comedi core module");
Expand Down Expand Up @@ -2156,7 +2156,6 @@ int comedi_alloc_board_minor(struct device *hardware_device)
}
return i;
}
EXPORT_SYMBOL_GPL(comedi_alloc_board_minor);

void comedi_free_board_minor(unsigned minor)
{
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/comedi/comedidev.h
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,6 @@ static inline void *comedi_aux_data(int options[], int n)
return (void *)address;
}

int comedi_alloc_board_minor(struct device *hardware_device);
void comedi_free_board_minor(unsigned minor);
int comedi_alloc_subdevice_minor(struct comedi_device *dev,
struct comedi_subdevice *s);
Expand Down
5 changes: 3 additions & 2 deletions drivers/staging/comedi/drivers.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,16 @@
#include <linux/ioport.h>
#include <linux/mm.h>
#include <linux/slab.h>
#include "comedidev.h"
#include <linux/highmem.h> /* for SuSE brokenness */
#include <linux/vmalloc.h>
#include <linux/cdev.h>
#include <linux/dma-mapping.h>

#include <linux/io.h>
#include <asm/system.h>

#include "comedidev.h"
#include "internal.h"

static int postconfig(struct comedi_device *dev);
static int insn_rw_emulate_bits(struct comedi_device *dev,
struct comedi_subdevice *s,
Expand Down
2 changes: 2 additions & 0 deletions drivers/staging/comedi/internal.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

int comedi_alloc_board_minor(struct device *hardware_device);

0 comments on commit 242e7ad

Please sign in to comment.