Skip to content

Commit

Permalink
nfs: nfs4xdr: simplify decode_exchange_id by reusing decode_opaque_in…
Browse files Browse the repository at this point in the history
…line

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Benny Halevy authored and Trond Myklebust committed Aug 14, 2009
1 parent 99398d0 commit 2460ba5
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions fs/nfs/nfs4xdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -4144,6 +4144,7 @@ static int decode_exchange_id(struct xdr_stream *xdr,
{
__be32 *p;
uint32_t dummy;
char *dummy_str;
int status;
struct nfs_client *clp = res->client;

Expand All @@ -4166,19 +4167,19 @@ static int decode_exchange_id(struct xdr_stream *xdr,
READ_BUF(8);

/* Throw away Major id */
READ_BUF(4);
dummy = be32_to_cpup(p++);
READ_BUF(dummy);
status = decode_opaque_inline(xdr, &dummy, &dummy_str);
if (unlikely(status))
return status;

/* Throw away server_scope */
READ_BUF(4);
dummy = be32_to_cpup(p++);
READ_BUF(dummy);
status = decode_opaque_inline(xdr, &dummy, &dummy_str);
if (unlikely(status))
return status;

/* Throw away Implementation id array */
READ_BUF(4);
dummy = be32_to_cpup(p++);
READ_BUF(dummy);
status = decode_opaque_inline(xdr, &dummy, &dummy_str);
if (unlikely(status))
return status;

return 0;
}
Expand Down

0 comments on commit 2460ba5

Please sign in to comment.