Skip to content

Commit

Permalink
V4L/DVB (3568i): adv7175: Drop unused register cache
Browse files Browse the repository at this point in the history
Drop the adv7175 register cache, as it is only written to and never read back
from.  This saves 128 bytes of memory and slightly speeds up the register
writes.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Jean Delvare authored and Mauro Carvalho Chehab committed Mar 23, 2006
1 parent 2f8de1a commit 2467a67
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/media/video/adv7175.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ MODULE_PARM_DESC(debug, "Debug level (0-1)");
/* ----------------------------------------------------------------------- */

struct adv7175 {
unsigned char reg[128];

int norm;
int input;
int enable;
Expand All @@ -95,9 +93,6 @@ adv7175_write (struct i2c_client *client,
u8 reg,
u8 value)
{
struct adv7175 *encoder = i2c_get_clientdata(client);

encoder->reg[reg] = value;
return i2c_smbus_write_byte_data(client, reg, value);
}

Expand All @@ -120,7 +115,6 @@ adv7175_write_block (struct i2c_client *client,
* the adapter understands raw I2C */
if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
/* do raw I2C, not smbus compatible */
struct adv7175 *encoder = i2c_get_clientdata(client);
struct i2c_msg msg;
u8 block_data[32];

Expand All @@ -131,8 +125,8 @@ adv7175_write_block (struct i2c_client *client,
msg.len = 0;
block_data[msg.len++] = reg = data[0];
do {
block_data[msg.len++] =
encoder->reg[reg++] = data[1];
block_data[msg.len++] = data[1];
reg++;
len -= 2;
data += 2;
} while (len >= 2 && data[0] == reg &&
Expand Down

0 comments on commit 2467a67

Please sign in to comment.