Skip to content

Commit

Permalink
PM / QoS: Add pm_qos_update_target/flags tracepoints
Browse files Browse the repository at this point in the history
This patch adds tracepoints to pm_qos_update_target and
pm_qos_update_flags. It's useful for checking pm qos action,
previous value and current value.

Signed-off-by: Sahara <keun-o.park@windriver.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Sahara authored and Rafael J. Wysocki committed Jun 24, 2013
1 parent d30b82a commit 247e9ee
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 0 deletions.
51 changes: 51 additions & 0 deletions include/trace/events/power.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#define _TRACE_POWER_H

#include <linux/ktime.h>
#include <linux/pm_qos.h>
#include <linux/tracepoint.h>

DECLARE_EVENT_CLASS(cpu,
Expand Down Expand Up @@ -177,6 +178,56 @@ DEFINE_EVENT(power_domain, power_domain_target,

TP_ARGS(name, state, cpu_id)
);

/*
* The pm qos events are used for pm qos update
*/
DECLARE_EVENT_CLASS(pm_qos_update,

TP_PROTO(enum pm_qos_req_action action, int prev_value, int curr_value),

TP_ARGS(action, prev_value, curr_value),

TP_STRUCT__entry(
__field( enum pm_qos_req_action, action )
__field( int, prev_value )
__field( int, curr_value )
),

TP_fast_assign(
__entry->action = action;
__entry->prev_value = prev_value;
__entry->curr_value = curr_value;
),

TP_printk("action=%s prev_value=%d curr_value=%d",
__print_symbolic(__entry->action,
{ PM_QOS_ADD_REQ, "ADD_REQ" },
{ PM_QOS_UPDATE_REQ, "UPDATE_REQ" },
{ PM_QOS_REMOVE_REQ, "REMOVE_REQ" }),
__entry->prev_value, __entry->curr_value)
);

DEFINE_EVENT(pm_qos_update, pm_qos_update_target,

TP_PROTO(enum pm_qos_req_action action, int prev_value, int curr_value),

TP_ARGS(action, prev_value, curr_value)
);

DEFINE_EVENT_PRINT(pm_qos_update, pm_qos_update_flags,

TP_PROTO(enum pm_qos_req_action action, int prev_value, int curr_value),

TP_ARGS(action, prev_value, curr_value),

TP_printk("action=%s prev_value=0x%x curr_value=0x%x",
__print_symbolic(__entry->action,
{ PM_QOS_ADD_REQ, "ADD_REQ" },
{ PM_QOS_UPDATE_REQ, "UPDATE_REQ" },
{ PM_QOS_REMOVE_REQ, "REMOVE_REQ" }),
__entry->prev_value, __entry->curr_value)
);
#endif /* _TRACE_POWER_H */

/* This part must be outside protection */
Expand Down
3 changes: 3 additions & 0 deletions kernel/power/qos.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@

#include <linux/uaccess.h>
#include <linux/export.h>
#include <trace/events/power.h>

/*
* locking rule: all changes to constraints or notifiers lists
Expand Down Expand Up @@ -202,6 +203,7 @@ int pm_qos_update_target(struct pm_qos_constraints *c, struct plist_node *node,

spin_unlock_irqrestore(&pm_qos_lock, flags);

trace_pm_qos_update_target(action, prev_value, curr_value);
if (prev_value != curr_value) {
blocking_notifier_call_chain(c->notifiers,
(unsigned long)curr_value,
Expand Down Expand Up @@ -272,6 +274,7 @@ bool pm_qos_update_flags(struct pm_qos_flags *pqf,

spin_unlock_irqrestore(&pm_qos_lock, irqflags);

trace_pm_qos_update_flags(action, prev_value, curr_value);
return prev_value != curr_value;
}

Expand Down

0 comments on commit 247e9ee

Please sign in to comment.