Skip to content

Commit

Permalink
qeth: no write permission for readonly sysattr
Browse files Browse the repository at this point in the history
User is not allowed to write into bridge_state sysfs file.
Fixed attribute not mislead the user

Signed-off-by: Lakhvich Dmitriy <ldmitriy@ru.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Reported-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Reviewed-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Reviewed-by: Thomas Richter <tmricht@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Lakhvich Dmitriy authored and David S. Miller committed Sep 21, 2015
1 parent 9846e70 commit 248046b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/s390/net/qeth_l2_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static ssize_t qeth_bridge_port_state_show(struct device *dev,
return qeth_bridge_port_role_state_show(dev, attr, buf, 1);
}

static DEVICE_ATTR(bridge_state, 0644, qeth_bridge_port_state_show,
static DEVICE_ATTR(bridge_state, 0444, qeth_bridge_port_state_show,
NULL);

static ssize_t qeth_bridgeport_hostnotification_show(struct device *dev,
Expand Down

0 comments on commit 248046b

Please sign in to comment.