Skip to content

Commit

Permalink
MIPS: Ralink: Use strlcpy() instead of strncpy().
Browse files Browse the repository at this point in the history
'compatible' is used by strlen() in __of_device_is_compatible().

Ensure strings are always '\0' terminated.

'of_ids is not a structure in "include/uapi/*", so no need to initialize
it completly; using strlcpy() instead of strncpy() will do.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
Cc: juhosg@openwrt.org
Cc: linux-mips@linux-mips.org
Cc: Linux-Arch <linux-arch@vger.kernel.org>
Patchwork: https://patchwork.linux-mips.org/patch/5330/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Chen Gang authored and Ralf Baechle committed Jun 10, 2013
1 parent 90a6fb1 commit 24b1944
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/mips/ralink/of.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static int __init plat_of_setup(void)
if (!of_have_populated_dt())
panic("device tree not present");

strncpy(of_ids[0].compatible, soc_info.compatible, len);
strlcpy(of_ids[0].compatible, soc_info.compatible, len);
strncpy(of_ids[1].compatible, "palmbus", len);

if (of_platform_populate(NULL, of_ids, NULL, NULL))
Expand Down

0 comments on commit 24b1944

Please sign in to comment.