Skip to content

Commit

Permalink
No need for crossing to mountpoint in audit_tag_tree()
Browse files Browse the repository at this point in the history
is_under() will DTRT anyway.  And yes, is_subdir() behaviour
is intentional.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Apr 21, 2009
1 parent 1644ccc commit 24b6f16
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion fs/dcache.c
Original file line number Diff line number Diff line change
Expand Up @@ -2149,7 +2149,6 @@ int is_subdir(struct dentry *new_dentry, struct dentry *old_dentry)
int result;
unsigned long seq;

/* FIXME: This is old behavior, needed? Please check callers. */
if (new_dentry == old_dentry)
return 1;

Expand Down
3 changes: 0 additions & 3 deletions kernel/audit_tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,9 +734,6 @@ int audit_tag_tree(char *old, char *new)
dentry = dget(path.dentry);
path_put(&path);

if (dentry == tagged->mnt_root && dentry == mnt->mnt_root)
follow_up(&mnt, &dentry);

list_add_tail(&list, &tagged->mnt_list);

mutex_lock(&audit_filter_mutex);
Expand Down

0 comments on commit 24b6f16

Please sign in to comment.