Skip to content

Commit

Permalink
staging: olpc_dcon: remove noinit module variable
Browse files Browse the repository at this point in the history
This came from Jordan's original 2007 gxfb_dcon commit.  I've never
seen or heard of it actually being used.  Presumably it was once
useful for skipping hardware initialization when reloading the module
over and over during driver development..

Signed-off-by: Andres Salomon <dilinger@queued.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Andres Salomon authored and Greg Kroah-Hartman committed Aug 23, 2011
1 parent d6a32aa commit 24e2617
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/staging/olpc_dcon/olpc_dcon.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
static int resumeline = 898;
module_param(resumeline, int, 0444);

static int noinit;
module_param(noinit, int, 0444);

/* Default off since it doesn't work on DCON ASIC in B-test OLPC board */
static int useaa = 1;
module_param(useaa, int, 0444);
Expand Down Expand Up @@ -90,7 +87,7 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init)
}
}

if (ver < 0xdc02 && !noinit) {
if (ver < 0xdc02) {
/* Initialize the DCON registers */

/* Start with work-arounds for DCON ASIC */
Expand All @@ -106,7 +103,7 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init)
i2c_smbus_write_word_data(client, 0x3b, 0x002b);
i2c_smbus_write_word_data(client, 0x41, 0x0101);
i2c_smbus_write_word_data(client, 0x42, 0x0101);
} else if (!noinit) {
} else {
/* SDRAM setup/hold time */
i2c_smbus_write_word_data(client, 0x3a, 0xc040);
i2c_smbus_write_word_data(client, 0x41, 0x0000);
Expand Down

0 comments on commit 24e2617

Please sign in to comment.