Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 131104
b: refs/heads/master
c: f12b12a
h: refs/heads/master
v: v3
  • Loading branch information
Linus Torvalds committed Feb 7, 2009
1 parent 8825818 commit 24f048f
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2d29c6a075787f2c1bc49b86a084d2b878f72fc4
refs/heads/master: f12b12a8aecfcafcf2f9df1c1658d2484959dfda
2 changes: 1 addition & 1 deletion trunk/fs/compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,7 @@ int compat_do_execve(char * filename,
bprm->cred = prepare_exec_creds();
if (!bprm->cred)
goto out_unlock;
check_unsafe_exec(bprm);
check_unsafe_exec(bprm, current->files);

file = open_exec(filename);
retval = PTR_ERR(file);
Expand Down
28 changes: 22 additions & 6 deletions trunk/fs/exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1049,16 +1049,32 @@ EXPORT_SYMBOL(install_exec_creds);
* - the caller must hold current->cred_exec_mutex to protect against
* PTRACE_ATTACH
*/
void check_unsafe_exec(struct linux_binprm *bprm)
void check_unsafe_exec(struct linux_binprm *bprm, struct files_struct *files)
{
struct task_struct *p = current;
struct task_struct *p = current, *t;
unsigned long flags;
unsigned n_fs, n_files, n_sighand;

bprm->unsafe = tracehook_unsafe_exec(p);

if (atomic_read(&p->fs->count) > 1 ||
atomic_read(&p->files->count) > 1 ||
atomic_read(&p->sighand->count) > 1)
n_fs = 1;
n_files = 1;
n_sighand = 1;
lock_task_sighand(p, &flags);
for (t = next_thread(p); t != p; t = next_thread(t)) {
if (t->fs == p->fs)
n_fs++;
if (t->files == files)
n_files++;
n_sighand++;
}

if (atomic_read(&p->fs->count) > n_fs ||
atomic_read(&p->files->count) > n_files ||
atomic_read(&p->sighand->count) > n_sighand)
bprm->unsafe |= LSM_UNSAFE_SHARE;

unlock_task_sighand(p, &flags);
}

/*
Expand Down Expand Up @@ -1273,7 +1289,7 @@ int do_execve(char * filename,
bprm->cred = prepare_exec_creds();
if (!bprm->cred)
goto out_unlock;
check_unsafe_exec(bprm);
check_unsafe_exec(bprm, displaced);

file = open_exec(filename);
retval = PTR_ERR(file);
Expand Down
2 changes: 1 addition & 1 deletion trunk/fs/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ extern void __init chrdev_init(void);
/*
* exec.c
*/
extern void check_unsafe_exec(struct linux_binprm *);
extern void check_unsafe_exec(struct linux_binprm *, struct files_struct *);

/*
* namespace.c
Expand Down

0 comments on commit 24f048f

Please sign in to comment.