Skip to content

Commit

Permalink
ath5k: correct interrupt storm warning
Browse files Browse the repository at this point in the history
Ben Greear points out that the "too many interrupts" message will
never print in the intended case since the interrupt counter
will be -1 after the loop.  Change it to pre-decrement so it will
be 0 on the thousandth iteration.

Cc: Ben Greear <greearb@candelatech.com>

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Bob Copeland authored and John W. Linville committed May 6, 2009
1 parent 35f00cf commit 2516baa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/ath/ath5k/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,7 @@ ath5k_intr(int irq, void *dev_id)
ath5k_hw_update_mib_counters(ah, &sc->ll_stats);
}
}
} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);
} while (ath5k_hw_is_intr_pending(ah) && --counter > 0);

if (unlikely(!counter))
ATH5K_WARN(sc, "too many interrupts, giving up for now\n");
Expand Down

0 comments on commit 2516baa

Please sign in to comment.