Skip to content

Commit

Permalink
mm: allow preemption in apply_to_pte_range
Browse files Browse the repository at this point in the history
Impact: allow preemption in apply_to_pte_range updates to init_mm

Preemption is now allowed for lazy mmu mode, so don't disable
it for the inner loop of apply_to_pte_range.  This only applies
when doing updates to init_mm; user pagetables are still modified
under the pte lock, so preemption is disabled anyway.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
  • Loading branch information
Jeremy Fitzhardinge committed Mar 30, 2009
1 parent 2829b44 commit 252a6bf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions mm/memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -1718,7 +1718,6 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,

BUG_ON(pmd_huge(*pmd));

preempt_disable();
arch_enter_lazy_mmu_mode();

token = pmd_pgtable(*pmd);
Expand All @@ -1730,7 +1729,6 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
} while (pte++, addr += PAGE_SIZE, addr != end);

arch_leave_lazy_mmu_mode();
preempt_enable();

if (mm != &init_mm)
pte_unmap_unlock(pte-1, ptl);
Expand Down

0 comments on commit 252a6bf

Please sign in to comment.