Skip to content

Commit

Permalink
[SCSI] ips: handle scsi_add_host() failure, and other err cleanups
Browse files Browse the repository at this point in the history
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Acked-by: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Jeff Garzik authored and James Bottomley committed Jan 12, 2008
1 parent 21e1a5f commit 2551a13
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions drivers/scsi/ips.c
Original file line number Diff line number Diff line change
Expand Up @@ -6837,13 +6837,10 @@ ips_register_scsi(int index)
if (request_irq(ha->pcidev->irq, do_ipsintr, IRQF_SHARED, ips_name, ha)) {
IPS_PRINTK(KERN_WARNING, ha->pcidev,
"Unable to install interrupt handler\n");
scsi_host_put(sh);
return -1;
goto err_out_sh;
}

kfree(oldha);
ips_sh[index] = sh;
ips_ha[index] = ha;

/* Store away needed values for later use */
sh->unique_id = (ha->io_addr) ? ha->io_addr : ha->mem_addr;
Expand All @@ -6859,10 +6856,21 @@ ips_register_scsi(int index)
sh->max_channel = ha->nbus - 1;
sh->can_queue = ha->max_cmds - 1;

scsi_add_host(sh, NULL);
if (scsi_add_host(sh, &ha->pcidev->dev))
goto err_out;

ips_sh[index] = sh;
ips_ha[index] = ha;

scsi_scan_host(sh);

return 0;

err_out:
free_irq(ha->pcidev->irq, ha);
err_out_sh:
scsi_host_put(sh);
return -1;
}

/*---------------------------------------------------------------------------*/
Expand Down

0 comments on commit 2551a13

Please sign in to comment.