Skip to content

Commit

Permalink
Bluetooth: Improve rx debug logs for Three-wire UART
Browse files Browse the repository at this point in the history
Remove unnecessary debug logs and add some to more centralized places.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
  • Loading branch information
Johan Hedberg authored and Gustavo Padovan committed Jul 17, 2012
1 parent cd1b442 commit 255a68e
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions drivers/bluetooth/hci_h5.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,6 @@ static void h5_complete_rx_pkt(struct hci_uart *hu)
struct h5 *h5 = hu->priv;
const unsigned char *hdr = h5->rx_skb->data;

BT_DBG("%s", hu->hdev->name);

if (H5_HDR_RELIABLE(hdr)) {
h5->tx_ack = (h5->tx_ack + 1) % 8;
h5->tx_ack_req = true;
Expand Down Expand Up @@ -284,8 +282,6 @@ static int h5_rx_crc(struct hci_uart *hu, unsigned char c)
{
struct h5 *h5 = hu->priv;

BT_DBG("%s 0x%02hhx", hu->hdev->name, c);

h5_complete_rx_pkt(hu);
h5_reset_rx(h5);

Expand All @@ -297,8 +293,6 @@ static int h5_rx_payload(struct hci_uart *hu, unsigned char c)
struct h5 *h5 = hu->priv;
const unsigned char *hdr = h5->rx_skb->data;

BT_DBG("%s 0x%02hhx", hu->hdev->name, c);

if (H5_HDR_CRC(hdr)) {
h5->rx_func = h5_rx_crc;
h5->rx_pending = 2;
Expand All @@ -315,8 +309,6 @@ static int h5_rx_3wire_hdr(struct hci_uart *hu, unsigned char c)
struct h5 *h5 = hu->priv;
const unsigned char *hdr = h5->rx_skb->data;

BT_DBG("%s 0x%02hhx", hu->hdev->name, c);

BT_DBG("%s rx: seq %u ack %u crc %u rel %u type %u len %u",
hu->hdev->name, H5_HDR_SEQ(hdr), H5_HDR_ACK(hdr),
H5_HDR_CRC(hdr), H5_HDR_RELIABLE(hdr), H5_HDR_PKT_TYPE(hdr),
Expand Down Expand Up @@ -345,8 +337,6 @@ static int h5_rx_pkt_start(struct hci_uart *hu, unsigned char c)
{
struct h5 *h5 = hu->priv;

BT_DBG("%s 0x%02hhx", hu->hdev->name, c);

if (c == SLIP_DELIMITER)
return 1;

Expand All @@ -369,8 +359,6 @@ static int h5_rx_delimiter(struct hci_uart *hu, unsigned char c)
{
struct h5 *h5 = hu->priv;

BT_DBG("%s 0x%02hhx", hu->hdev->name, c);

if (c == SLIP_DELIMITER)
h5->rx_func = h5_rx_pkt_start;

Expand Down Expand Up @@ -407,7 +395,7 @@ static void h5_unslip_one_byte(struct h5 *h5, unsigned char c)
memcpy(skb_put(h5->rx_skb, 1), byte, 1);
h5->rx_pending--;

BT_DBG("unsliped 0x%02hhx", *byte);
BT_DBG("unsliped 0x%02hhx, rx_pending %zu", *byte, h5->rx_pending);
}

static void h5_reset_rx(struct h5 *h5)
Expand All @@ -427,7 +415,8 @@ static int h5_recv(struct hci_uart *hu, void *data, int count)
struct h5 *h5 = hu->priv;
unsigned char *ptr = data;

BT_DBG("%s count %d", hu->hdev->name, count);
BT_DBG("%s pending %zu count %d", hu->hdev->name, h5->rx_pending,
count);

while (count > 0) {
int processed;
Expand Down

0 comments on commit 255a68e

Please sign in to comment.