Skip to content

Commit

Permalink
mac80211: Fix ieee80211_rx_reorder_ampdu: ignore QoS null packets
Browse files Browse the repository at this point in the history
This patch fixes the check at the entrance to ieee80211_rx_reorder_ampdu.
This check has been broken by 'mac80211: rx.c use new helpers'.

Letting QoS NULL packet in ieee80211_rx_reorder_ampdu led to packet loss in
RX.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Emmanuel Grumbach authored and John W. Linville committed Jul 14, 2008
1 parent 4ece16a commit 2560b6e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/mac80211/rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2041,8 +2041,8 @@ static u8 ieee80211_rx_reorder_ampdu(struct ieee80211_local *local,

tid_agg_rx = sta->ampdu_mlme.tid_rx[tid];

/* null data frames are excluded */
if (unlikely(ieee80211_is_nullfunc(hdr->frame_control)))
/* qos null data frames are excluded */
if (unlikely(hdr->frame_control & cpu_to_le16(IEEE80211_STYPE_NULLFUNC)))
goto end_reorder;

/* new un-ordered ampdu frame - process it */
Expand Down

0 comments on commit 2560b6e

Please sign in to comment.