Skip to content

Commit

Permalink
staging/rtl8187se: Remove code without effect
Browse files Browse the repository at this point in the history
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.

-> the local variables u1bAIFS, eACI and pAcParam can also be removed.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Peter Huewe authored and Greg Kroah-Hartman committed Feb 15, 2013
1 parent e9d077b commit 2578180
Showing 1 changed file with 1 addition and 38 deletions.
39 changes: 1 addition & 38 deletions drivers/staging/rtl8187se/r8185b_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -928,44 +928,7 @@ void ActUpdateChannelAccessSetting(struct net_device *dev,

for (eACI = 0; eACI < AC_MAX; eACI++) {
AcParam.f.AciAifsn.f.ACI = (u8)eACI;
{
PAC_PARAM pAcParam = (PAC_PARAM)(&AcParam);
AC_CODING eACI;
u8 u1bAIFS;
u32 u4bAcParam;

/* Retrieve parameters to update. */
eACI = pAcParam->f.AciAifsn.f.ACI;
u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * ChnlAccessSetting->SlotTimeTimer + aSifsTime;
u4bAcParam = ((((u32)(pAcParam->f.TXOPLimit)) << AC_PARAM_TXOP_LIMIT_OFFSET) |
(((u32)(pAcParam->f.Ecw.f.ECWmax)) << AC_PARAM_ECW_MAX_OFFSET) |
(((u32)(pAcParam->f.Ecw.f.ECWmin)) << AC_PARAM_ECW_MIN_OFFSET) |
(((u32)u1bAIFS) << AC_PARAM_AIFS_OFFSET));

switch (eACI) {
case AC1_BK:
/* write_nic_dword(dev, AC_BK_PARAM, u4bAcParam); */
break;

case AC0_BE:
/* write_nic_dword(dev, AC_BK_PARAM, u4bAcParam); */
break;

case AC2_VI:
/* write_nic_dword(dev, AC_BK_PARAM, u4bAcParam); */
break;

case AC3_VO:
/* write_nic_dword(dev, AC_BK_PARAM, u4bAcParam); */
break;

default:
DMESGW("SetHwReg8185(): invalid ACI: %d !\n", eACI);
break;
}

write_nic_byte(dev, ACM_CONTROL, 0);
}
write_nic_byte(dev, ACM_CONTROL, 0);
}
}
}
Expand Down

0 comments on commit 2578180

Please sign in to comment.