Skip to content

Commit

Permalink
[media] drxk: Improve logging
Browse files Browse the repository at this point in the history
This patch simply fixes some logging calls:
- Use KERN_INFO when printing the chip status.
- Add a missing space when logging the drxk_gate_ctrl call.
- Use the same logging text as always if the scu_command in GetQAMLockStatus fails.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Martin Blumenstingl authored and Mauro Carvalho Chehab committed Jul 6, 2012
1 parent 7eaf718 commit 257ee97
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/media/dvb/frontends/drxk_hard.c
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ static int GetDeviceCapabilities(struct drxk_state *state)
if (status < 0)
goto error;

printk(KERN_ERR "drxk: status = 0x%08x\n", sioTopJtagidLo);
printk(KERN_INFO "drxk: status = 0x%08x\n", sioTopJtagidLo);

/* driver 0.9.0 */
switch ((sioTopJtagidLo >> 29) & 0xF) {
Expand Down Expand Up @@ -5388,7 +5388,7 @@ static int GetQAMLockStatus(struct drxk_state *state, u32 *pLockStatus)
SCU_RAM_COMMAND_CMD_DEMOD_GET_LOCK, 0, NULL, 2,
Result);
if (status < 0)
printk(KERN_ERR "drxk: %s status = %08x\n", __func__, status);
printk(KERN_ERR "drxk: Error %d on %s\n", status, __func__);

if (Result[1] < SCU_RAM_QAM_LOCKED_LOCKED_DEMOD_LOCKED) {
/* 0x0000 NOT LOCKED */
Expand Down Expand Up @@ -6329,7 +6329,7 @@ static int drxk_gate_ctrl(struct dvb_frontend *fe, int enable)
{
struct drxk_state *state = fe->demodulator_priv;

dprintk(1, "%s\n", enable ? "enable" : "disable");
dprintk(1, ": %s\n", enable ? "enable" : "disable");

if (state->m_DrxkState == DRXK_NO_DEV)
return -ENODEV;
Expand Down

0 comments on commit 257ee97

Please sign in to comment.