Skip to content

Commit

Permalink
rrunner: fix buffer overflow
Browse files Browse the repository at this point in the history
tx_skbuff is define as:
        struct sk_buff          *tx_skbuff[TX_RING_ENTRIES];

EVT_RING_ENTRIES is 64 and TX_RING_ENTRIES is 32.

This function is in a error path so that's why it wasn't noticed.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Jan 4, 2010
1 parent 7ec4e7d commit 2585e7e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/rrunner.c
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ static void rr_dump(struct net_device *dev)

printk("Error code 0x%x\n", readl(&regs->Fail1));

index = (((readl(&regs->EvtPrd) >> 8) & 0xff ) - 1) % EVT_RING_ENTRIES;
index = (((readl(&regs->EvtPrd) >> 8) & 0xff) - 1) % TX_RING_ENTRIES;
cons = rrpriv->dirty_tx;
printk("TX ring index %i, TX consumer %i\n",
index, cons);
Expand Down

0 comments on commit 2585e7e

Please sign in to comment.