Skip to content

Commit

Permalink
pinctrl: Remove unsafe __refdata
Browse files Browse the repository at this point in the history
A pin controller's pin definitions are used both during pinctrl_register()
and pinctrl_unregister(). The latter happens outside of __init/__devinit
time, and hence it is unsafe to mark the pin array as __refdata.

Acked-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Stephen Warren authored and Linus Walleij committed Oct 20, 2011
1 parent a5818a8 commit 25aec32
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/pinctrl/pinmux-sirf.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* pad list for the pinmux subsystem
* refer to CS-131858-DC-6A.xls
*/
static const struct pinctrl_pin_desc __refdata sirfsoc_pads[] = {
static const struct pinctrl_pin_desc sirfsoc_pads[] = {
PINCTRL_PIN(4, "pwm0"),
PINCTRL_PIN(5, "pwm1"),
PINCTRL_PIN(6, "pwm2"),
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/pinmux-u300.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
#define U300_NUM_PADS 467

/* Pad names for the pinmux subsystem */
static const struct pinctrl_pin_desc __refdata u300_pads[] = {
static const struct pinctrl_pin_desc u300_pads[] = {
/* Pads along the top edge of the chip */
PINCTRL_PIN(0, "P PAD VDD 28"),
PINCTRL_PIN(1, "P PAD GND 28"),
Expand Down

0 comments on commit 25aec32

Please sign in to comment.