Skip to content

Commit

Permalink
hp-wmi: remove a variable that is never read
Browse files Browse the repository at this point in the history
Remove the status variable from hp_wmi_perform_query which holds the
return value from wmi_evaluate_method(). It is never checked as the
function bails out if the output buffer hasn't been allocated which
indicates the call failed.

Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
  • Loading branch information
Anssi Hannula authored and Matthew Garrett committed Mar 28, 2011
1 parent 9af0e0f commit 25bb067
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/platform/x86/hp-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ static int hp_wmi_perform_query(int query, int write, u32 *buffer,
int buffersize)
{
struct bios_return bios_return;
acpi_status status;
union acpi_object *obj;
struct bios_args args = {
.signature = 0x55434553,
Expand All @@ -165,7 +164,7 @@ static int hp_wmi_perform_query(int query, int write, u32 *buffer,
struct acpi_buffer input = { sizeof(struct bios_args), &args };
struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };

status = wmi_evaluate_method(HPWMI_BIOS_GUID, 0, 0x3, &input, &output);
wmi_evaluate_method(HPWMI_BIOS_GUID, 0, 0x3, &input, &output);

obj = output.pointer;

Expand Down

0 comments on commit 25bb067

Please sign in to comment.