Skip to content

Commit

Permalink
[Bluetooth] Remaining transitions to use kzalloc()
Browse files Browse the repository at this point in the history
This patch makes the remaining transitions to use kzalloc().

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Marcel Holtmann authored and David S. Miller committed Jul 12, 2006
1 parent c2ce920 commit 25ea6db
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 25 deletions.
4 changes: 1 addition & 3 deletions net/bluetooth/cmtp/capi.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,13 @@

static struct cmtp_application *cmtp_application_add(struct cmtp_session *session, __u16 appl)
{
struct cmtp_application *app = kmalloc(sizeof(*app), GFP_KERNEL);
struct cmtp_application *app = kzalloc(sizeof(*app), GFP_KERNEL);

BT_DBG("session %p application %p appl %d", session, app, appl);

if (!app)
return NULL;

memset(app, 0, sizeof(*app));

app->state = BT_OPEN;
app->appl = appl;

Expand Down
3 changes: 1 addition & 2 deletions net/bluetooth/cmtp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,9 @@ int cmtp_add_connection(struct cmtp_connadd_req *req, struct socket *sock)
baswap(&src, &bt_sk(sock->sk)->src);
baswap(&dst, &bt_sk(sock->sk)->dst);

session = kmalloc(sizeof(struct cmtp_session), GFP_KERNEL);
session = kzalloc(sizeof(struct cmtp_session), GFP_KERNEL);
if (!session)
return -ENOMEM;
memset(session, 0, sizeof(struct cmtp_session));

down_write(&cmtp_session_sem);

Expand Down
7 changes: 2 additions & 5 deletions net/bluetooth/hci_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,8 @@ void hci_inquiry_cache_update(struct hci_dev *hdev, struct inquiry_data *data)

if (!(e = hci_inquiry_cache_lookup(hdev, &data->bdaddr))) {
/* Entry not in the cache. Add new one. */
if (!(e = kmalloc(sizeof(struct inquiry_entry), GFP_ATOMIC)))
if (!(e = kzalloc(sizeof(struct inquiry_entry), GFP_ATOMIC)))
return;
memset(e, 0, sizeof(struct inquiry_entry));
e->next = cache->list;
cache->list = e;
}
Expand Down Expand Up @@ -800,12 +799,10 @@ struct hci_dev *hci_alloc_dev(void)
{
struct hci_dev *hdev;

hdev = kmalloc(sizeof(struct hci_dev), GFP_KERNEL);
hdev = kzalloc(sizeof(struct hci_dev), GFP_KERNEL);
if (!hdev)
return NULL;

memset(hdev, 0, sizeof(struct hci_dev));

skb_queue_head_init(&hdev->driver_init);

return hdev;
Expand Down
3 changes: 1 addition & 2 deletions net/bluetooth/hidp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -582,10 +582,9 @@ int hidp_add_connection(struct hidp_connadd_req *req, struct socket *ctrl_sock,
bacmp(&bt_sk(ctrl_sock->sk)->dst, &bt_sk(intr_sock->sk)->dst))
return -ENOTUNIQ;

session = kmalloc(sizeof(struct hidp_session), GFP_KERNEL);
session = kzalloc(sizeof(struct hidp_session), GFP_KERNEL);
if (!session)
return -ENOMEM;
memset(session, 0, sizeof(struct hidp_session));

session->input = input_allocate_device();
if (!session->input) {
Expand Down
9 changes: 5 additions & 4 deletions net/bluetooth/rfcomm/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,10 @@ static void rfcomm_dlc_clear_state(struct rfcomm_dlc *d)

struct rfcomm_dlc *rfcomm_dlc_alloc(gfp_t prio)
{
struct rfcomm_dlc *d = kmalloc(sizeof(*d), prio);
struct rfcomm_dlc *d = kzalloc(sizeof(*d), prio);

if (!d)
return NULL;
memset(d, 0, sizeof(*d));

init_timer(&d->timer);
d->timer.function = rfcomm_dlc_timeout;
Expand All @@ -289,6 +289,7 @@ struct rfcomm_dlc *rfcomm_dlc_alloc(gfp_t prio)
rfcomm_dlc_clear_state(d);

BT_DBG("%p", d);

return d;
}

Expand Down Expand Up @@ -522,10 +523,10 @@ int rfcomm_dlc_get_modem_status(struct rfcomm_dlc *d, u8 *v24_sig)
/* ---- RFCOMM sessions ---- */
static struct rfcomm_session *rfcomm_session_add(struct socket *sock, int state)
{
struct rfcomm_session *s = kmalloc(sizeof(*s), GFP_KERNEL);
struct rfcomm_session *s = kzalloc(sizeof(*s), GFP_KERNEL);

if (!s)
return NULL;
memset(s, 0, sizeof(*s));

BT_DBG("session %p sock %p", s, sock);

Expand Down
3 changes: 1 addition & 2 deletions net/bluetooth/rfcomm/tty.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,9 @@ static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)

BT_DBG("id %d channel %d", req->dev_id, req->channel);

dev = kmalloc(sizeof(struct rfcomm_dev), GFP_KERNEL);
dev = kzalloc(sizeof(struct rfcomm_dev), GFP_KERNEL);
if (!dev)
return -ENOMEM;
memset(dev, 0, sizeof(struct rfcomm_dev));

write_lock_bh(&rfcomm_dev_lock);

Expand Down
12 changes: 5 additions & 7 deletions net/bluetooth/sco.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,14 @@ static void sco_sock_init_timer(struct sock *sk)
static struct sco_conn *sco_conn_add(struct hci_conn *hcon, __u8 status)
{
struct hci_dev *hdev = hcon->hdev;
struct sco_conn *conn;

if ((conn = hcon->sco_data))
return conn;
struct sco_conn *conn = hcon->sco_data;

if (status)
if (conn || status)
return conn;

if (!(conn = kmalloc(sizeof(struct sco_conn), GFP_ATOMIC)))
conn = kzalloc(sizeof(struct sco_conn), GFP_ATOMIC);
if (!conn)
return NULL;
memset(conn, 0, sizeof(struct sco_conn));

spin_lock_init(&conn->lock);

Expand All @@ -134,6 +131,7 @@ static struct sco_conn *sco_conn_add(struct hci_conn *hcon, __u8 status)
conn->mtu = 60;

BT_DBG("hcon %p conn %p", hcon, conn);

return conn;
}

Expand Down

0 comments on commit 25ea6db

Please sign in to comment.