Skip to content

Commit

Permalink
sctp: fix oops when updating retransmit path with DEBUG on
Browse files Browse the repository at this point in the history
commit fbdf501
  sctp: Do no select unconfirmed transports for retransmissions

Introduced the initial falt.

commit d598b16
  sctp: Make sure we always return valid retransmit path

Solved the problem, but forgot to change the DEBUG statement.
Thus it was still possible to dereference a NULL pointer.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vlad Yasevich authored and David S. Miller committed Apr 13, 2011
1 parent 31d8b9e commit 25f7bf7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/sctp/associola.c
Original file line number Diff line number Diff line change
Expand Up @@ -1323,6 +1323,8 @@ void sctp_assoc_update_retran_path(struct sctp_association *asoc)

if (t)
asoc->peer.retran_path = t;
else
t = asoc->peer.retran_path;

SCTP_DEBUG_PRINTK_IPADDR("sctp_assoc_update_retran_path:association"
" %p addr: ",
Expand Down

0 comments on commit 25f7bf7

Please sign in to comment.