Skip to content

Commit

Permalink
usb: renesas_usbhs: send packet in necessary timing.
Browse files Browse the repository at this point in the history
Current renesas_usbhs driver always tries to send packet in end of recip handler.
But it breaks chapter 9 EndpointHalt test.
This patch fixup this issue.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Kuninori Morimoto authored and Felipe Balbi committed Dec 12, 2011
1 parent 17f7f76 commit 25fa707
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/usb/renesas_usbhs/mod_gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ static int usbhsg_recip_handler_std_clear_endpoint(struct usbhs_priv *priv,

usbhsg_recip_handler_std_control_done(priv, uep, ctrl);

usbhs_pkt_start(pipe);

return 0;
}

Expand Down Expand Up @@ -424,8 +426,7 @@ static int usbhsg_recip_run_handle(struct usbhs_priv *priv,
pipe = usbhsg_uep_to_pipe(uep);
if (!pipe) {
dev_err(dev, "wrong recip request\n");
ret = -EINVAL;
goto usbhsg_recip_run_handle_end;
return -EINVAL;
}

switch (recip) {
Expand All @@ -452,9 +453,6 @@ static int usbhsg_recip_run_handle(struct usbhs_priv *priv,
ret = func(priv, uep, ctrl);
}

usbhsg_recip_run_handle_end:
usbhs_pkt_start(pipe);

return ret;
}

Expand Down

0 comments on commit 25fa707

Please sign in to comment.