Skip to content

Commit

Permalink
staging/csr: Use kmemdup rather than duplicating its implementation
Browse files Browse the repository at this point in the history
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Peter Huewe authored and Greg Kroah-Hartman committed Jan 30, 2013
1 parent d662b8e commit 2643c47
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/staging/csr/drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -819,15 +819,15 @@ unifi_write(struct file *filp, const char *p, size_t len, loff_t *poff)
unifi_trace(priv, UDBG2, "unifi_write: signal 0x%.4X len:%d\n",
sig_id, signal_size);

/* Allocate a buffer for the signal */
signal_buf = kmalloc(signal_size, GFP_KERNEL);
/* Allocate a buffer for the signal */
signal_buf = kmemdup(bulkdata.d[0].os_data_ptr, signal_size,
GFP_KERNEL);
if (!signal_buf) {
unifi_net_data_free(priv, &bulkdata.d[0]);
return -ENOMEM;
}

/* Get the signal from the os_data_ptr */
memcpy(signal_buf, bulkdata.d[0].os_data_ptr, signal_size);
signal_buf[5] = (pcli->sender_id >> 8) & 0xff;

if (signal_size < len) {
Expand Down

0 comments on commit 2643c47

Please sign in to comment.