Skip to content

Commit

Permalink
nfsd: Don't unlock the state while it's not locked
Browse files Browse the repository at this point in the history
In the procedure of CREATE_SESSION, the state is locked after
alloc_conn_from_crses(). If the allocation fails, the function
goes to "out_free_session", and then "out" where there is an
unlock function.

Signed-off-by: Yanchuan Nian <ycnian@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
Yanchuan Nian authored and J. Bruce Fields committed Jan 23, 2013
1 parent 74b70dd commit 266533c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -1844,11 +1844,12 @@ nfsd4_create_session(struct svc_rqst *rqstp,

/* cache solo and embedded create sessions under the state lock */
nfsd4_cache_create_session(cr_ses, cs_slot, status);
out:
nfs4_unlock_state();
out:
dprintk("%s returns %d\n", __func__, ntohl(status));
return status;
out_free_conn:
nfs4_unlock_state();
free_conn(conn);
out_free_session:
__free_session(new);
Expand Down

0 comments on commit 266533c

Please sign in to comment.