Skip to content

Commit

Permalink
x86: fix incorrect __read_mostly on _boot_cpu_pda
Browse files Browse the repository at this point in the history
The pda rework (commit 3461b0a)
to remove static boot cpu pdas introduced a performance bug.

_boot_cpu_pda is the actual pda used by the boot cpu and is definitely
not "__read_mostly" and ended up polluting the read mostly section with
writes.  This bug caused regression of about 8-10% on certain syscall
intensive workloads.

Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Acked-by: Mike Travis <travis@sgi.com>
Cc: <stable@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ravikiran G Thirumalai authored and Ingo Molnar committed Jan 2, 2009
1 parent b58602a commit 26799a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/kernel/head64.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include <asm/trampoline.h>

/* boot cpu pda */
static struct x8664_pda _boot_cpu_pda __read_mostly;
static struct x8664_pda _boot_cpu_pda;

#ifdef CONFIG_SMP
/*
Expand Down

0 comments on commit 26799a6

Please sign in to comment.