Skip to content

Commit

Permalink
SLUB: get rid of finish_bootstrap
Browse files Browse the repository at this point in the history
Its only purpose was to bring some sort of symmetry to sysfs usage when
dealing with bootstrapping per cpu flushing.  Since we do not time out slabs
anymore we have no need to run finish_bootstrap even without sysfs.  Fold it
back into slab_sysfs_init and drop the initcall for the !SYFS case.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Christoph Lameter authored and Linus Torvalds committed May 9, 2007
1 parent 1f99a28 commit 26a7bd0
Showing 1 changed file with 10 additions and 20 deletions.
30 changes: 10 additions & 20 deletions mm/slub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1704,23 +1704,6 @@ static int calculate_sizes(struct kmem_cache *s)

}

static int __init finish_bootstrap(void)
{
struct list_head *h;
int err;

slab_state = SYSFS;

list_for_each(h, &slab_caches) {
struct kmem_cache *s =
container_of(h, struct kmem_cache, list);

err = sysfs_slab_add(s);
BUG_ON(err);
}
return 0;
}

static int kmem_cache_open(struct kmem_cache *s, gfp_t gfpflags,
const char *name, size_t size,
size_t align, unsigned long flags,
Expand Down Expand Up @@ -3482,6 +3465,7 @@ static int sysfs_slab_alias(struct kmem_cache *s, const char *name)

static int __init slab_sysfs_init(void)
{
struct list_head *h;
int err;

err = subsystem_register(&slab_subsys);
Expand All @@ -3490,7 +3474,15 @@ static int __init slab_sysfs_init(void)
return -ENOSYS;
}

finish_bootstrap();
slab_state = SYSFS;

list_for_each(h, &slab_caches) {
struct kmem_cache *s =
container_of(h, struct kmem_cache, list);

err = sysfs_slab_add(s);
BUG_ON(err);
}

while (alias_list) {
struct saved_alias *al = alias_list;
Expand All @@ -3506,6 +3498,4 @@ static int __init slab_sysfs_init(void)
}

__initcall(slab_sysfs_init);
#else
__initcall(finish_bootstrap);
#endif

0 comments on commit 26a7bd0

Please sign in to comment.