Skip to content

Commit

Permalink
thermal: step_wise: fix: Prevent from binary overflow when trend is d…
Browse files Browse the repository at this point in the history
…ropping

It turns out that some boards can have instance->lower greater than 0 and
when thermal trend is dropping it results with next_target equal to -1.

Since the next_target is defined as unsigned long it is interpreted as
0xFFFFFFFF and larger than instance->upper.
As a result the next_target is set to instance->upper which ramps up to
maximal cooling device target when the temperature is steadily decreasing.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
  • Loading branch information
Lukasz Majewski authored and Zhang Rui committed Oct 9, 2014
1 parent 52addcf commit 26bb0e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/thermal/step_wise.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static unsigned long get_target_state(struct thermal_instance *instance,
next_target = instance->upper;
break;
case THERMAL_TREND_DROPPING:
if (cur_state == instance->lower) {
if (cur_state <= instance->lower) {
if (!throttle)
next_target = THERMAL_NO_TARGET;
} else {
Expand Down

0 comments on commit 26bb0e9

Please sign in to comment.