Skip to content

Commit

Permalink
fbcon: uninline four foo_update_attr() functions
Browse files Browse the repository at this point in the history
This patch uninlines four similar functions, foo_update_attr(), in four
fbcon-related files.

These functions contain loops, two of theam have _nested_ loops, and they
have more than one callsite each.  I think they should not be inlined.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Denys Vlasenko authored and Linus Torvalds committed Aug 11, 2010
1 parent da909ce commit 26c5be3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/video/console/bitblit.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/*
* Accelerated handlers.
*/
static inline void update_attr(u8 *dst, u8 *src, int attribute,
static void update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc)
{
int i, offset = (vc->vc_font.height < 10) ? 1 : 2;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/console/fbcon_ccw.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Rotation 270 degrees
*/

static inline void ccw_update_attr(u8 *dst, u8 *src, int attribute,
static void ccw_update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc)
{
int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/console/fbcon_cw.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Rotation 90 degrees
*/

static inline void cw_update_attr(u8 *dst, u8 *src, int attribute,
static void cw_update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc)
{
int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/console/fbcon_ud.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Rotation 180 degrees
*/

static inline void ud_update_attr(u8 *dst, u8 *src, int attribute,
static void ud_update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc)
{
int i, offset = (vc->vc_font.height < 10) ? 1 : 2;
Expand Down

0 comments on commit 26c5be3

Please sign in to comment.