Skip to content

Commit

Permalink
NFSv4: Fix an Oops in nfs_do_expire_all_delegations
Browse files Browse the repository at this point in the history
 If the loop errors, we need to exit.

 Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed Jan 6, 2006
1 parent 58df095 commit 26c78e1
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions fs/nfs/delegation.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ int nfs_do_expire_all_delegations(void *ptr)
struct nfs4_client *clp = ptr;
struct nfs_delegation *delegation;
struct inode *inode;
int err = 0;

allow_signal(SIGKILL);
restart:
Expand All @@ -250,10 +249,9 @@ int nfs_do_expire_all_delegations(void *ptr)
if (inode == NULL)
continue;
spin_unlock(&clp->cl_lock);
err = nfs_inode_return_delegation(inode);
nfs_inode_return_delegation(inode);
iput(inode);
if (!err)
goto restart;
goto restart;
}
out:
spin_unlock(&clp->cl_lock);
Expand Down

0 comments on commit 26c78e1

Please sign in to comment.