Skip to content

Commit

Permalink
Revert "ixgbe: disable MSI-X by default on certain Cisco adapters"
Browse files Browse the repository at this point in the history
This reverts commit d5ffd75.

As requested by Jeff Kircher.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed May 3, 2010
1 parent cd7b539 commit 26d2784
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
4 changes: 0 additions & 4 deletions drivers/net/ixgbe/ixgbe.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@
#define MAX_EMULATION_MAC_ADDRS 16
#define VMDQ_P(p) ((p) + adapter->num_vfs)

#define IXGBE_SUBDEV_ID_82598AF_MEZZ 0x0049
#define IXGBE_SUBDEV_ID_82598AF_MENLO_Q_MEZZ 0x004a
#define IXGBE_SUBDEV_ID_82598AF_MENLO_E_MEZZ 0x004b

struct vf_data_storage {
unsigned char vf_mac_addresses[ETH_ALEN];
u16 vf_mc_hashes[IXGBE_MAX_VF_MC_ENTRIES];
Expand Down
17 changes: 1 addition & 16 deletions drivers/net/ixgbe/ixgbe_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -4314,9 +4314,6 @@ static int ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
int err = 0;
int vector, v_budget;

if (!(adapter->flags & IXGBE_FLAG_MSIX_CAPABLE))
goto try_msi;

/*
* It's easy to be greedy for MSI-X vectors, but it really
* doesn't do us much good if we have a lot more vectors
Expand Down Expand Up @@ -4348,7 +4345,7 @@ static int ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED)
goto out;
}
try_msi:

adapter->flags &= ~IXGBE_FLAG_DCB_ENABLED;
adapter->flags &= ~IXGBE_FLAG_RSS_ENABLED;
adapter->flags &= ~IXGBE_FLAG_FDIR_HASH_CAPABLE;
Expand Down Expand Up @@ -4629,18 +4626,6 @@ static int __devinit ixgbe_sw_init(struct ixgbe_adapter *adapter)
adapter->ring_feature[RING_F_RSS].indices = rss;
adapter->flags |= IXGBE_FLAG_RSS_ENABLED;
adapter->ring_feature[RING_F_DCB].indices = IXGBE_MAX_DCB_INDICES;
adapter->flags |= IXGBE_FLAG_MSIX_CAPABLE;
if (adapter->hw.device_id == IXGBE_DEV_ID_82598AF_DUAL_PORT) {
switch (adapter->hw.subsystem_device_id) {
case IXGBE_SUBDEV_ID_82598AF_MEZZ:
case IXGBE_SUBDEV_ID_82598AF_MENLO_Q_MEZZ:
case IXGBE_SUBDEV_ID_82598AF_MENLO_E_MEZZ:
adapter->flags &= ~IXGBE_FLAG_MSIX_CAPABLE;
break;
default:
break;
}
}
if (hw->mac.type == ixgbe_mac_82598EB) {
if (hw->device_id == IXGBE_DEV_ID_82598AT)
adapter->flags |= IXGBE_FLAG_FAN_FAIL_CAPABLE;
Expand Down

0 comments on commit 26d2784

Please sign in to comment.