Skip to content

Commit

Permalink
USB: gadget: g_mass_storage: static data instead of dynamic allocation
Browse files Browse the repository at this point in the history
This patch changes msg_do_config() function so that it uses
a static object for a fsg_common structure instead of dynamically
allocated.  This is a micro-optimisation.

Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Michal Nazarewicz authored and Greg Kroah-Hartman committed Aug 10, 2010
1 parent 3b759c7 commit 26eca10
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions drivers/usb/gadget/mass_storage.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ static int msg_thread_exits(struct fsg_common *common)

static int __init msg_do_config(struct usb_configuration *c)
{
struct fsg_common *common;
static struct fsg_common common;

struct fsg_common *retp;
struct fsg_config config;
int ret;

Expand All @@ -154,12 +156,13 @@ static int __init msg_do_config(struct usb_configuration *c)

fsg_config_from_params(&config, &mod_data);
config.thread_exits = msg_thread_exits;
common = fsg_common_init(0, c->cdev, &config);
if (IS_ERR(common))
return PTR_ERR(common);

ret = fsg_add(c->cdev, c, common);
fsg_common_put(common);
retp = fsg_common_init(&common, c->cdev, &config);
if (IS_ERR(retp))
return PTR_ERR(retp);

ret = fsg_add(c->cdev, c, &common);
fsg_common_put(&common);
return ret;
}

Expand Down

0 comments on commit 26eca10

Please sign in to comment.