Skip to content

Commit

Permalink
[PARISC] Quiet sysfs_create_link __must_check warnings in pdc_stable
Browse files Browse the repository at this point in the history
Failing to create the links doesn't seem like a fatal error in these
paths. WARN_ON seems better than nothing though.

Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
  • Loading branch information
Kyle McMartin authored and Kyle McMartin committed Oct 18, 2007
1 parent 19c4d56 commit 26f0324
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/parisc/pdc_stable.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const char *buf, size_t coun
unsigned short i;
char in[count+1], *temp;
struct device *dev;
int ret;

if (!entry || !buf || !count)
return -EINVAL;
Expand Down Expand Up @@ -333,7 +334,9 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const char *buf, size_t coun

/* Update the symlink to the real device */
sysfs_remove_link(&entry->kobj, "device");
sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
ret = sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
WARN_ON(ret);

write_unlock(&entry->rw_lock);

printk(KERN_INFO PDCS_PREFIX ": changed \"%s\" path to \"%s\"\n",
Expand Down Expand Up @@ -1003,8 +1006,10 @@ pdcs_register_pathentries(void)
entry->ready = 2;

/* Add a nice symlink to the real device */
if (entry->dev)
sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
if (entry->dev) {
err = sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
WARN_ON(err);
}

write_unlock(&entry->rw_lock);
}
Expand Down

0 comments on commit 26f0324

Please sign in to comment.