Skip to content

Commit

Permalink
staging: rtl8192u: replace msleep(1) with usleep_range() in r819xU_phy.c
Browse files Browse the repository at this point in the history
This patch fixes the following checkpatch warning:
WARNING: msleep < 20ms can sleep for up to 20ms

The implementation of msleep() is based on jiffies timeout
subsystem. Hence, its resolution is constrained by the value
of HZ tick rate. When HZ variable is configured to 100,
the jiffies variable is updated every 10 ms, so a timeout
of 1ms cannot be met using jiffies (it will be rounded up
to 10ms).

This patch replaces msleep(1) with usleep_range(1000, 1000).
usleep_range() uses hrtimers subsystem which is not bound
to HZ value and can provide microsecond-level resolution.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Xenia Ragiadakou authored and Greg Kroah-Hartman committed Jun 24, 2013
1 parent a60d4d6 commit 26f3561
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/staging/rtl8192u/r819xU_phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ u32 rtl8192_phy_RFSerialRead(struct net_device *dev, RF90_RADIO_PATH_E eRFPath,


/* TODO: we should not delay such a long time. Ask for help from SD3 */
msleep(1);
usleep_range(1000, 1000);

ret = rtl8192_QueryBBReg(dev, pPhyReg->rfLSSIReadBack,
bLSSIReadBackData);
Expand Down Expand Up @@ -741,11 +741,11 @@ u8 rtl8192_phy_checkBBAndRF(struct net_device *dev, HW90_BLOCK_E CheckBlock,
bMask12Bits, WriteData[i]);
/* TODO: we should not delay for such a long time.
Ask SD3 */
msleep(1);
usleep_range(1000, 1000);
reg = rtl8192_phy_QueryRFReg(dev, eRFPath,
WriteAddr[HW90_BLOCK_RF],
bMask12Bits);
msleep(1);
usleep_range(1000, 1000);
break;

default:
Expand Down

0 comments on commit 26f3561

Please sign in to comment.