Skip to content

Commit

Permalink
xen: make CPU hotplug functions static
Browse files Browse the repository at this point in the history
There's no need for these functions to be accessed from outside of xen/smp.c

Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Alex Nixon authored and Ingo Molnar committed Sep 8, 2008
1 parent 2737146 commit 26fd105
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
12 changes: 6 additions & 6 deletions arch/x86/xen/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ static void xen_smp_cpus_done(unsigned int max_cpus)
}

#ifdef CONFIG_HOTPLUG_CPU
int xen_cpu_disable(void)
static int xen_cpu_disable(void)
{
unsigned int cpu = smp_processor_id();
if (cpu == 0)
Expand All @@ -345,7 +345,7 @@ int xen_cpu_disable(void)
return 0;
}

void xen_cpu_die(unsigned int cpu)
static void xen_cpu_die(unsigned int cpu)
{
while (HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
current->state = TASK_UNINTERRUPTIBLE;
Expand All @@ -362,25 +362,25 @@ void xen_cpu_die(unsigned int cpu)
alternatives_smp_switch(0);
}

void xen_play_dead(void)
static void xen_play_dead(void)
{
play_dead_common();
HYPERVISOR_vcpu_op(VCPUOP_down, smp_processor_id(), NULL);
cpu_bringup();
}

#else /* !CONFIG_HOTPLUG_CPU */
int xen_cpu_disable(void)
static int xen_cpu_disable(void)
{
return -ENOSYS;
}

void xen_cpu_die(unsigned int cpu)
static void xen_cpu_die(unsigned int cpu)
{
BUG();
}

void xen_play_dead(void)
static void xen_play_dead(void)
{
BUG();
}
Expand Down
4 changes: 0 additions & 4 deletions arch/x86/xen/xen-ops.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ void xen_mark_init_mm_pinned(void);

void __init xen_setup_vcpu_info_placement(void);

void xen_play_dead(void);
void xen_cpu_die(unsigned int cpu);
int xen_cpu_disable(void);

#ifdef CONFIG_SMP
void xen_smp_init(void);

Expand Down

0 comments on commit 26fd105

Please sign in to comment.