Skip to content

Commit

Permalink
sc92031: use netdev_alloc_skb
Browse files Browse the repository at this point in the history
Use netdev_alloc_skb since it handles any NUMA node memory localtion issues
and sets skb->dev. Since device driver was not setting skb->dev, I bet
filter rules based on device would not work.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Stephen Hemminger authored and Jeff Garzik committed Apr 17, 2008
1 parent 26a17b7 commit 2723b01
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/sc92031.c
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ static void _sc92031_rx_tasklet(struct net_device *dev)

rx_len -= rx_size_align + 4;

skb = dev_alloc_skb(pkt_size + NET_IP_ALIGN);
skb = netdev_alloc_skb(dev, pkt_size + NET_IP_ALIGN);
if (unlikely(!skb)) {
if (printk_ratelimit())
printk(KERN_ERR "%s: Couldn't allocate a skb_buff for a packet of size %u\n",
Expand Down

0 comments on commit 2723b01

Please sign in to comment.