Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 226851
b: refs/heads/master
c: a0b8987
h: refs/heads/master
i:
  226849: 6bbcacf
  226847: 43016ee
v: v3
  • Loading branch information
Stephen M. Cameron authored and James Bottomley committed Dec 21, 2010
1 parent 883b5e4 commit 274054e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 774342844f368a0c3ba907f192d844ae337d01aa
refs/heads/master: a0b89872b305bd0f6f5af1dd26274a3f057a2303
9 changes: 0 additions & 9 deletions trunk/drivers/scsi/hpsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -641,11 +641,6 @@ static void fixup_botched_add(struct ctlr_info *h,
static inline int device_is_the_same(struct hpsa_scsi_dev_t *dev1,
struct hpsa_scsi_dev_t *dev2)
{
if ((is_logical_dev_addr_mode(dev1->scsi3addr) ||
(dev1->lun != -1 && dev2->lun != -1)) &&
dev1->devtype != 0x0C)
return (memcmp(dev1, dev2, sizeof(*dev1)) == 0);

/* we compare everything except lun and target as these
* are not yet assigned. Compare parts likely
* to differ first
Expand All @@ -660,8 +655,6 @@ static inline int device_is_the_same(struct hpsa_scsi_dev_t *dev1,
return 0;
if (memcmp(dev1->vendor, dev2->vendor, sizeof(dev1->vendor)) != 0)
return 0;
if (memcmp(dev1->revision, dev2->revision, sizeof(dev1->revision)) != 0)
return 0;
if (dev1->devtype != dev2->devtype)
return 0;
if (dev1->raid_level != dev2->raid_level)
Expand Down Expand Up @@ -1477,8 +1470,6 @@ static int hpsa_update_device_info(struct ctlr_info *h,
sizeof(this_device->vendor));
memcpy(this_device->model, &inq_buff[16],
sizeof(this_device->model));
memcpy(this_device->revision, &inq_buff[32],
sizeof(this_device->revision));
memset(this_device->device_id, 0,
sizeof(this_device->device_id));
hpsa_get_device_id(h, scsi3addr, this_device->device_id,
Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/scsi/hpsa.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ struct hpsa_scsi_dev_t {
unsigned char device_id[16]; /* from inquiry pg. 0x83 */
unsigned char vendor[8]; /* bytes 8-15 of inquiry data */
unsigned char model[16]; /* bytes 16-31 of inquiry data */
unsigned char revision[4]; /* bytes 32-35 of inquiry data */
unsigned char raid_level; /* from inquiry page 0xC1 */
};

Expand Down

0 comments on commit 274054e

Please sign in to comment.