---

yaml
---
r: 202443
b: refs/heads/master
c: b95d13e
h: refs/heads/master
i:
  202441: 067ab61
  202439: 8349217
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 0385e5210c83b13fe685c54b6063655f80bce3ee
+refs/heads/master: b95d13eaf3d4ea093aba95c7f615f3b10708a2c4

trunk/drivers/platform/x86/classmate-laptop.c

@@ -573,16 +573,17 @@ static int cmpc_ipml_add(struct acpi_device *acpi)
 
 	ipml->rf = rfkill_alloc("cmpc_rfkill", &acpi->dev, RFKILL_TYPE_WLAN,
 				&cmpc_rfkill_ops, acpi->handle);
-	/* rfkill_alloc may fail if RFKILL is disabled. We should still work
-	 * anyway. */
-	if (!IS_ERR(ipml->rf)) {
+	/*
+	 * If RFKILL is disabled, rfkill_alloc will return ERR_PTR(-ENODEV).
+	 * This is OK, however, since all other uses of the device will not
+	 * derefence it.
+	 */
+	if (ipml->rf) {
 		retval = rfkill_register(ipml->rf);
 		if (retval) {
 			rfkill_destroy(ipml->rf);
 			ipml->rf = NULL;
 		}
-	} else {
-		ipml->rf = NULL;
 	}
 
 	dev_set_drvdata(&acpi->dev, ipml);