Skip to content

Commit

Permalink
drm/cirrus: Remove unnecessary NULL check in bo_unref
Browse files Browse the repository at this point in the history
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Apr 22, 2014
1 parent 4cb8802 commit 275c632
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpu/drm/cirrus/cirrus_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,7 @@ static void cirrus_bo_unref(struct cirrus_bo **bo)

tbo = &((*bo)->bo);
ttm_bo_unref(&tbo);
if (tbo == NULL)
*bo = NULL;

*bo = NULL;
}

void cirrus_gem_free_object(struct drm_gem_object *obj)
Expand Down

0 comments on commit 275c632

Please sign in to comment.