Skip to content

Commit

Permalink
ALSA: hda: dynamic jack id
Browse files Browse the repository at this point in the history
This patch duplicates the jack->id pointer with kstrdup() to prevent
scoping issues from calling autoprobing functions from the HDA section.

Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Matthew Ranostay authored and Takashi Iwai committed Oct 27, 2008
1 parent a53ccab commit 282cd76
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sound/core/jack.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ static int snd_jack_dev_free(struct snd_device *device)
else
input_free_device(jack->input_dev);

kfree(jack->id);
kfree(jack);

return 0;
Expand Down Expand Up @@ -87,7 +88,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
if (jack == NULL)
return -ENOMEM;

jack->id = id;
jack->id = kstrdup(id, GFP_KERNEL);

jack->input_dev = input_allocate_device();
if (jack->input_dev == NULL) {
Expand Down

0 comments on commit 282cd76

Please sign in to comment.