Skip to content

Commit

Permalink
powerpc/mpc5121: avoid using arch_initcall for clock init
Browse files Browse the repository at this point in the history
Move mpc5121_clk_init() call to platform init code so it won't
get called on non-5121 platforms on a multiplatform kernel.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Anatolij Gustschin authored and Grant Likely committed Feb 16, 2010
1 parent 724e6d3 commit 284ed66
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
6 changes: 1 addition & 5 deletions arch/powerpc/platforms/512x/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,7 @@ static struct clk_interface mpc5121_clk_functions = {
.clk_get_parent = NULL,
};

static int
mpc5121_clk_init(void)
int __init mpc5121_clk_init(void)
{
struct device_node *np;

Expand All @@ -724,6 +723,3 @@ mpc5121_clk_init(void)
clk_functions = mpc5121_clk_functions;
return 0;
}


arch_initcall(mpc5121_clk_init);
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/512x/mpc5121_ads.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ define_machine(mpc5121_ads) {
.name = "MPC5121 ADS",
.probe = mpc5121_ads_probe,
.setup_arch = mpc5121_ads_setup_arch,
.init = mpc512x_declare_of_platform_devices,
.init = mpc512x_init,
.init_IRQ = mpc5121_ads_init_IRQ,
.get_irq = ipic_get_irq,
.calibrate_decr = generic_calibrate_decr,
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/512x/mpc5121_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ static int __init mpc5121_generic_probe(void)
define_machine(mpc5121_generic) {
.name = "MPC5121 generic",
.probe = mpc5121_generic_probe,
.init = mpc512x_declare_of_platform_devices,
.init = mpc512x_init,
.init_IRQ = mpc512x_init_IRQ,
.get_irq = ipic_get_irq,
.calibrate_decr = generic_calibrate_decr,
Expand Down
2 changes: 2 additions & 0 deletions arch/powerpc/platforms/512x/mpc512x.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@
#ifndef __MPC512X_H__
#define __MPC512X_H__
extern void __init mpc512x_init_IRQ(void);
extern void __init mpc512x_init(void);
extern int __init mpc5121_clk_init(void);
void __init mpc512x_declare_of_platform_devices(void);
#endif /* __MPC512X_H__ */
5 changes: 5 additions & 0 deletions arch/powerpc/platforms/512x/mpc512x_shared.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,8 @@ void __init mpc512x_declare_of_platform_devices(void)
"Error while probing of_platform bus\n");
}

void __init mpc512x_init(void)
{
mpc512x_declare_of_platform_devices();
mpc5121_clk_init();
}

0 comments on commit 284ed66

Please sign in to comment.