Skip to content

Commit

Permalink
bridge: fix accidental creation of sysfs directory
Browse files Browse the repository at this point in the history
Commit bb900b2 ("bridge: allow
creating bridge devices with netlink") introduced a bug in net-next
because of a typo in notifier. Every device would have the sysfs
bridge directory (and files).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Apr 18, 2011
1 parent 2ed28ba commit 28674b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bridge/br_notify.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v
int err;

/* register of bridge completed, add sysfs entries */
if ((dev->priv_flags && IFF_EBRIDGE) && event == NETDEV_REGISTER) {
if ((dev->priv_flags & IFF_EBRIDGE) && event == NETDEV_REGISTER) {
br_sysfs_addbr(dev);
return NOTIFY_DONE;
}
Expand Down

0 comments on commit 28674b9

Please sign in to comment.