Skip to content

Commit

Permalink
[SPARC64]: Kill starfire_cookie from SBUS/PCI.
Browse files Browse the repository at this point in the history
Totally unused.

We need to traverse the list of global IRQ translaters,
so storing it in the per-bus structures was useless.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller authored and David S. Miller committed Jun 29, 2006
1 parent bf7e851 commit 286bbe8
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 13 deletions.
4 changes: 1 addition & 3 deletions arch/sparc64/kernel/pci_psycho.c
Original file line number Diff line number Diff line change
Expand Up @@ -1171,9 +1171,7 @@ static void psycho_iommu_init(struct pci_controller_info *p)

/* If necessary, hook us up for starfire IRQ translations. */
if (this_is_starfire)
p->starfire_cookie = starfire_hookup(p->pbm_A.portid);
else
p->starfire_cookie = NULL;
starfire_hookup(p->pbm_A.portid);
}

#define PSYCHO_IRQ_RETRY 0x1a00UL
Expand Down
4 changes: 1 addition & 3 deletions arch/sparc64/kernel/sbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -1221,9 +1221,7 @@ static void __init sbus_iommu_init(int __node, struct sbus_bus *sbus)

/* Now some Xfire specific grot... */
if (this_is_starfire)
sbus->starfire_cookie = starfire_hookup(sbus->portid);
else
sbus->starfire_cookie = NULL;
starfire_hookup(sbus->portid);

sysio_register_error_handlers(sbus);
}
Expand Down
4 changes: 1 addition & 3 deletions arch/sparc64/kernel/starfire.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ struct starfire_irqinfo {
static struct starfire_irqinfo *sflist = NULL;

/* Beam me up Scott(McNeil)y... */
void *starfire_hookup(int upaid)
void starfire_hookup(int upaid)
{
struct starfire_irqinfo *p;
unsigned long treg_base, hwmid, i;
Expand All @@ -81,8 +81,6 @@ void *starfire_hookup(int upaid)
p->upaid = upaid;
p->next = sflist;
sflist = p;

return (void *) p;
}

unsigned int starfire_translate(unsigned long imap,
Expand Down
2 changes: 0 additions & 2 deletions include/asm-sparc64/pbm.h
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@ struct pci_controller_info {
struct pci_ops *pci_ops;
unsigned int pci_first_busno;
unsigned int pci_last_busno;

void *starfire_cookie;
};

/* PCI devices which are not bridges have this placed in their pci_dev
Expand Down
1 change: 0 additions & 1 deletion include/asm-sparc64/sbus.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ struct sbus_bus {
int num_sbus_ranges;

int portid;
void *starfire_cookie;
};
#define to_sbus(d) container_of(d, struct sbus_bus, ofdev.dev)

Expand Down
2 changes: 1 addition & 1 deletion include/asm-sparc64/starfire.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ extern int this_is_starfire;
extern void check_if_starfire(void);
extern void starfire_cpu_setup(void);
extern int starfire_hard_smp_processor_id(void);
extern void *starfire_hookup(int);
extern void starfire_hookup(int);
extern unsigned int starfire_translate(unsigned long imap, unsigned int upaid);

#endif
Expand Down

0 comments on commit 286bbe8

Please sign in to comment.