Skip to content

Commit

Permalink
x86/vdso: Make the PER_CPU segment 32 bits
Browse files Browse the repository at this point in the history
IMO users ought not to be able to use 16-bit segments without
using modify_ldt.  Fortunately, it's impossible to break
espfix64 by loading the PER_CPU segment into SS because it's
PER_CPU is marked read-only and SS cannot contain an RO segment,
but marking PER_CPU as 32-bit is less fragile.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/r/179f490d659307873eefd09206bebd417e2ab5ad.1411494540.git.luto@amacapital.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Andy Lutomirski authored and Ingo Molnar committed Oct 28, 2014
1 parent 9c0080e commit 287e013
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/x86/vdso/vma.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ static void vsyscall_set_cpu(int cpu)
.dpl = 3, /* Visible to user code */
.s = 1, /* Not a system segment */
.p = 1, /* Present */
.d = 1, /* 32-bit */
};

write_gdt_entry(get_cpu_gdt_table(cpu), GDT_ENTRY_PER_CPU, &d, DESCTYPE_S);
Expand Down

0 comments on commit 287e013

Please sign in to comment.