Skip to content

Commit

Permalink
viafb: fix sparse warnings
Browse files Browse the repository at this point in the history
Fix this sparse warnings:

  drivers/video/via/viafbdev.c:871:3: warning: returning void-valued expression
  drivers/video/via/viafbdev.c:938:3: warning: returning void-valued expression
  drivers/video/via/viafbdev.c:995:3: warning: returning void-valued expression

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Hannes Eder authored and Linus Torvalds committed Jan 6, 2009
1 parent 6875145 commit 2899bb0
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions drivers/video/via/viafbdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -870,8 +870,10 @@ static void viafb_fillrect(struct fb_info *info,
u32 col = 0, rop = 0;
int pitch;

if (!viafb_accel)
return cfb_fillrect(info, rect);
if (!viafb_accel) {
cfb_fillrect(info, rect);
return;
}

if (!rect->width || !rect->height)
return;
Expand Down Expand Up @@ -937,8 +939,10 @@ static void viafb_copyarea(struct fb_info *info,

DEBUG_MSG(KERN_INFO "viafb_copyarea!!\n");

if (!viafb_accel)
return cfb_copyarea(info, area);
if (!viafb_accel) {
cfb_copyarea(info, area);
return;
}

if (!area->width || !area->height)
return;
Expand Down Expand Up @@ -994,8 +998,10 @@ static void viafb_imageblit(struct fb_info *info,
int i;
int pitch;

if (!viafb_accel)
return cfb_imageblit(info, image);
if (!viafb_accel) {
cfb_imageblit(info, image);
return;
}

udata = (u32 *) image->data;

Expand Down

0 comments on commit 2899bb0

Please sign in to comment.