Skip to content

Commit

Permalink
sky2: not random enough
Browse files Browse the repository at this point in the history
Don't use sky2 to seed random pool beacause the network packet arrival time
will not be truly random due to NAPI and interrupt mitigation.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
  • Loading branch information
Stephen Hemminger authored and Francois Romieu committed Mar 9, 2006
1 parent 39bf429 commit 28a3186
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -3243,8 +3243,7 @@ static int __devinit sky2_probe(struct pci_dev *pdev,
}
}

err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ | SA_SAMPLE_RANDOM,
DRV_NAME, hw);
err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ, DRV_NAME, hw);
if (err) {
printk(KERN_ERR PFX "%s: cannot assign irq %d\n",
pci_name(pdev), pdev->irq);
Expand Down

0 comments on commit 28a3186

Please sign in to comment.